Merged PRs

dolt

• 8600: Add testing for show slave status This syntax is deprecated and will be removed in future MySQL versions (SHOW REPLICA STATUS should be preferred instead). However, some tools (e.g. Dolphie, MyDumper) still rely on this deprecated syntax, so we're adding support for it to keep compatibility with those tools. Depends on:
  • https://github.com/dolthub/vitess/pull/381
  • https://github.com/dolthub/go-mysql-server/pull/2767
• 8596: go/store/nbs: table_index.go: Improve support for large table files. Support suffix arrays larger than 4GB by avoiding uint32 overflows when matching chunk suffixes.
• 8595: replace nil defaults with empty string Needed for dolphie.
• 8590: system variables cannot have nil defaults related: https://github.com/dolthub/dolt/issues/8585#issuecomment-2494754518
• 8589: Fix dolt_statistics table for multiple schemas for doltgres GMS PR: https://github.com/dolthub/go-mysql-server/pull/2762
• 8561: [kvexec] merge join This isn't the best perf win on linux, but it counteracts the sql.Row interface PR which otherwise would swing merge join +30% in the wrong direction.

  goos: darwin
  goarch: arm64
  pkg: github.com/dolthub/dolt/go/performance/microsysbench
  │  before.txt  │           after.txt           │
  │    sec/op    │    sec/op     vs base         │
  OltpJoinScan-12   680.6µ ± 26%   612.1µ ± 17%  ~ (p=0.240 n=6)
  │  before.txt  │              after.txt              │
  │     B/op     │     B/op      vs base               │
  OltpJoinScan-12   163.8Ki ± 0%   123.8Ki ± 0%  -24.42% (p=0.002 n=6)
  │ before.txt  │             after.txt              │
  │  allocs/op  │  allocs/op   vs base               │
  OltpJoinScan-12   5.906k ± 0%   4.233k ± 0%  -28.33% (p=0.002 n=6)
  

  TODO:
  • left join
  • nulls and other edge cases
  • execute full comparer

go-mysql-server

• 2773: Fixed error in setup found by user
• 2769: support NO_AUTO_CREATE_USER option in sql_mode Older MySQL 5.7 Docs; https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sqlmode_no_auto_create_user We already do this by default, so this is just parsing the option and does nothing.
• 2767: Add support for show slave status This syntax is deprecated and will be removed in future MySQL versions (SHOW REPLICA STATUS should be preferred instead). However, some tools (e.g. Dolphie, MyDumper) still rely on this deprecated syntax, so we're adding support for it to keep compatibility with those tools. Depends on: https://github.com/dolthub/vitess/pull/381
• 2766: add case for enum return types in multi-branch case statement Hotfix for Enum conversion issue: https://github.com/dolthub/dolt/issues/8598 Doesn't address real issue, which revolves around conversion for CASE.
• 2763: Better error message for invalid charset string This is a followup to the comments on this PR:
  • https://github.com/dolthub/go-mysql-server/pull/2758#event-15402633565
• 2762: Add schema to StatsQualifier for schema databases
• 2761: add innodb_buffer_pool_size system variable docs: https://dev.mysql.com/doc/refman/8.4/en/innodb-parameters.html#sysvar_innodb_buffer_pool_size
• 2759: ignore empty strings in sets with multiple values fixes: https://github.com/dolthub/dolt/issues/8584
• 2756: Update README - fix db name when setting context I'm pretty sure this needs to match with memory.NewDatabase(dbName) on line 135

vitess

• 384: add mariadb table opts and tests This PR adds support for parsing the mariadb table options listed here: https://mariadb.com/kb/en/create-table/#table-options They are all no-ops (much like many of the MySQL table options) related: https://github.com/dolthub/dolt/issues/8592
• 383: parse start transaction with consistent as no-op related: https://github.com/dolthub/dolt/issues/8592
• 382: Add syntax support to allow CREATE USER statements to quote the auth plugin MySQL allows the auth plugin name to be quoted or unquoted, but our parser previously only supported the unquoted mode for most forms of CREATE USER. This change adds support for the following forms:
  • CREATE USER user@localhost IDENTIFIED WITH 'auth_plugin';
  • CREATE USER user@localhost IDENTIFIED WITH 'auth_plugin' BY random password;
  • CREATE USER user@localhost IDENTIFIED WITH 'auth_plugin' BY 'password';
• 381: Add support for show slave status This syntax is deprecated and will be removed in future MySQL versions (SHOW REPLICA STATUS should be preferred instead). However, some tools (e.g. Dolphie, MyDumper) still rely on this deprecated syntax, so we're adding support for it to keep compatibility with those tools.
• 379: Refactor AuthServer to support multiple authentication methods In preparation of supporting caching_sha2_password authentication, this change applies the refactoring from https://github.com/vitessio/vitess/pull/8503 to our fork of Vitess so that we can more easily support multiple authentication methods. Related to: https://github.com/dolthub/dolt/issues/8496

Closed Issues