merge_pr_42609
版本发布时间: 2023-10-27 23:42:31
web-platform-tests/wpt最新发布版本:merge_pr_48029(2024-09-07 13:25:31)
Protected Audience: Enable leaveAdInterestGroup() without arguments in urn iframes and ad components.
This change has two parts:
- A bug fix: leaveAdInterestGroup() without arguments currently does not work from urn iframe, but it should.
- An enhancement: enable leaveAdInterestGroup() without arguments from ad component frames. This is guarded by a default-off feature flag.
Before this change, leaveAdInterestGroup() without arguments only works for frames loading main ads in fenced frames tree.
When calling leaveAdInterestGroup() without arguments, renderer will end up calling LeaveInterestGroupForDocument(). The check in this function on whether leaveAdInterestGroup is allowed to be called without arguments is moved to browser. This is because we do not have a good way to check whether a frame is an urn iframe at renderer.
If the set up does not allow it:
- behavior before this CL: throw a JS type error "owner and name are required outside of a fenced frame."
- behavior after this CL: show a console error "Owner and name are required to call LeaveAdInterestGroup outside of a fenced frame or an opaque origin iframe."
The web platform test checking this JS type error is removed. The console error is covered in browser tests.
Please let me know if this looks good, or should we just return without showing any error instead.
To enable it for ad components, ad auction data is copied to ad
components in AssignFencedFrameURLAndInterestGroupInfo()
.
Previously, it is only copied to the main frame's fenced frame
properties.
Added browser tests.
The support for leaving from ad component frames is gated on a default-off feature flag.
Bug: 1485219 Change-Id: I3e47423db99771e2823b3ff00449bb843efa8aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4879697 Commit-Queue: Xiaochen Zhou xiaochenzh@chromium.org Reviewed-by: Dominic Farolino dom@chromium.org Reviewed-by: Garrett Tanzer gtanzer@chromium.org Reviewed-by: Russ Hamilton behamilton@google.com Cr-Commit-Position: refs/heads/main@{#1216114}
1、 MANIFEST-92c259135697d6b4a50425200475f0a7beb613b5.json.bz2 2.35MB
2、 MANIFEST-92c259135697d6b4a50425200475f0a7beb613b5.json.gz 2.88MB
3、 MANIFEST-92c259135697d6b4a50425200475f0a7beb613b5.json.zst 2.36MB